Another one? There’s so many!
Sure, but did you know my Python library netwalk has support for configuring spanning-tree on Cisco switchports and Ansible does not?
Someone should do something about it.
Anyone?
Fine, I’ll do it myself.
In this post, I truly have absolutely no idea what I’m doing.
And I can’t wait to begin.
Ansible galaxy already has an official-looking package for cisco network devices, so let’s clone it and open it in an IDE.
I’ll try to follow the parsing of “l2 interfaces”, which manages assigning vlans and mode access/trunk
Ok, that’s a lot of files with the same name.
What do they do?
Let’s open them and figure out. Luckily they are all well-commented.
argspec
is an autogenerated file containing the data structure you can pass to the libraryconfig
, as per its description, is the file “where the current configuration (as dict) is compared to the provided configuration (as dict) and the command set necessary to bring the current configuration to its desired end-state is created.facts
: It is in this file the configuration is collected from the device for a given resource, parsed, and the facts tree is populated based on the configuration.- rm_templates: a list of parser definitions and associated functions that facilitates both facts gathering and native command generation for the given network resource.
modules
is the main entry point for module execution
So by logic, when we connect to a device we call something inside facts, which uses parsers defined in rm_templates to generate a dict that is used by config to find the differences and generate the appropriate commands to bring the config up to spec.
Unfortunately I haven’t been able to have VS Code debug this collection correctly (it hangs at gathering facts) so let’s
We’re going to start by writing a single test, copying test_l2_interface and crudely swapping all mentions of “l2” with “stp”, so the only thing we have to worry about is
def test_ios_stp_interfaces_merged(self): self.execute_show_command.return_value = dedent( """\ interface GigabitEthernet0/1 """, ) set_module_args( dict( config=[ dict( bpduguard=True, name="GigabitEthernet0/1", ), ], state="merged", ), ) commands = [ "interface GigabitEthernet0/1", "spanning-tree bpduguard enable", ] result = self.execute_module(changed=True) self.maxDiff = None self.assertEqual(result["commands"], commands)
Of course our linter has flared up like crazy because of all the missing dependencies, so let’s fix that too.
For now, I’ll limit to parsing whether bpduguard is True or False.
Is this compliant to Ansible best practices? I have no idea, I’m just throwing code at the interpreter to see what sticks.
Let’s create those files, always copying from their “l2” correspective.
OK I think I’ve found something interesting.
module_utils/network/ios/rm_templates/stp_interfaces.py contains a few lines that look like what I was looking for
PARSERS = [ { "name": "name", "getval": re.compile( r"""^interface (\s(?P<name>\S+)) $""", re.VERBOSE, ), "compval": "name", "setval": "interface {{ name }}", "result": {"{{ name }}": {"name": "{{ name }}"}}, "shared": True, }, { "name": "access.vlan", "getval": re.compile( r""" \s+switchport\saccess\svlan\s(?P<vlan>\d+) $""", re.VERBOSE, ), "setval": "switchport access vlan {{ access.vlan }}", "remval": "switchport access vlan", "result": { "{{ name }}": { "access": { "vlan": "{{ vlan }}", }, }, }, },
Looks like a set of regexes to parse the configuration, where each defines the path of the data to generate, a regex describing how to get the data, the command to set the desired config (setval), the command to remove the config (remval) and the result to return once the module is done.
Let’s write the first parser
{ "name": "bpduguard", "getval": re.compile( r""" \s+spanning-tree\sbpduguard\s(?P<bpduguard_status>\w+) $""", re.VERBOSE, ), "setval": "{{ 'spanning-tree bpduguard enable' if bpduguard == True}}", "remval": "no spanning-tree bpduguard", "result": { "{{ name }}": {"bpduguard": "{{ 'True' if bpduguard_status == 'enable' else 'False' }}"}, }, },
Moment of truth… let’s run a simple playbook set to “gather” the configuration, so it will parse it for us
Well! Looks like I only need to… parse… the entire… command tree… for spanning tree.
Remind me again why I even began doing this?
Anyway, the result of this post is available in this commit